Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Choose all" breaks with placeholder #2807

Closed
dburt opened this issue Jan 9, 2017 · 0 comments
Closed

"Choose all" breaks with placeholder #2807

dburt opened this issue Jan 9, 2017 · 0 comments
Milestone

Comments

@dburt
Copy link
Contributor

dburt commented Jan 9, 2017

Steps to reproduce:

  1. Find a has-many select field showing "Too many objects, use search box above" (or "No objects found")
  2. Click "Choose all -->"
  3. Click Save

An invalid params hash will include a field with contents like this and cause a validation error:

{
    "product_ids" => [
      "",
      "",
      "Too many objects, use search box above"
    ]
}

Suggested solution is to disable the "Choose all -->" link when a placeholder is present.

@mshibuya mshibuya added this to the 2.0.0 milestone Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants