Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method prepend_source! #102

Merged
merged 3 commits into from Aug 5, 2015

Conversation

eugenk
Copy link
Contributor

@eugenk eugenk commented Mar 5, 2015

Sometimes you want to have custom configuration files that are loaded
before the default files, in order to let the *.local.* files
overwrite those settings. This method enables this behaviour.

eugenk added a commit to ontohub/ontohub that referenced this pull request Mar 17, 2015
Now only two patches are used:
* overwrite_arrays (rubyconfig/config#99)
* prepend_source (rubyconfig/config#102)
@fredwu
Copy link
Member

fredwu commented Jun 27, 2015

That's a great addition @eugenk! 👍 Could you please add some tests and add the usage to the README? I'm happy to merge this once tests and README are updated. :)

Sometimes you want to have custom configuration files that are loaded
before the default files, in order to let the `*.local.*` files
overwrite those settings. This method enables this behaviour.
@eugenk eugenk force-pushed the add_method_prepend_source branch from 3b54cd8 to b16ec81 Compare July 1, 2015 07:40
@eugenk
Copy link
Contributor Author

eugenk commented Jul 1, 2015

Sure. I just rebased on master and added the specs and usage.

@eugenk
Copy link
Contributor Author

eugenk commented Jul 1, 2015

The specs fail with ruby 1.9.3, but I can't imagine how the failed specs are linked to the new code of this pull request.

@eugenk eugenk force-pushed the add_method_prepend_source branch from b16ec81 to d8722b8 Compare July 20, 2015 15:33
@fredwu
Copy link
Member

fredwu commented Aug 5, 2015

Nice work!

fredwu added a commit that referenced this pull request Aug 5, 2015
@fredwu fredwu merged commit 92217fd into rubyconfig:master Aug 5, 2015
@pkuczynski pkuczynski added this to the 0.3.pre milestone Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants