Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test outbox compatibility with sidekiq 7.0 #1442

Closed
swistak35 opened this issue Nov 5, 2022 · 1 comment
Closed

Test outbox compatibility with sidekiq 7.0 #1442

swistak35 opened this issue Nov 5, 2022 · 1 comment
Labels
outbox

Comments

@swistak35
Copy link
Contributor

I.e. there's warning:

2022-11-05T10:58:58.293Z pid=177926 tid=3tum WARN: Job arguments to CorrectAsyncHandler do not serialize to JSON safely. This will raise an error in Sidekiq 7.0. See https://github.com/mperham/sidekiq/wiki/Best-Practices or raise an error today
by calling `Sidekiq.strict_args!` during Sidekiq initialization

But it's most likely just from specs.
@lukaszreszke
Copy link
Contributor

Fixed in d45716c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
outbox
Projects
Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swistak35 @lukaszreszke