Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nitrous with codenvy in cloudservice guide #314

Merged
merged 2 commits into from Nov 22, 2016

Conversation

sssggr
Copy link
Member

@sssggr sssggr commented Nov 22, 2016

nitrous.io has shut down its service

nitrous.io has shut down its service
Copy link
Member

@titanoboa titanoboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, only two minor change requests

@@ -173,7 +173,7 @@ rake db:migrate
rails server
{% endhighlight %}

Open <http://localhost:3000/ideas> in your browser. Cloud service (e.g. nitrous) users need to append '/ideas' to their preview url instead (see [installation guide](/install#using-a-cloud-service)).
Open <http://localhost:3000/ideas> in your browser. Cloud service (e.g. ) users need to append '/ideas' to their preview url instead (see [installation guide](/install#using-a-cloud-service)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there is something missing, I think 'e.g. Codenvy' should be inside the parantheses

@@ -342,5 +360,8 @@ Go to [https://nitrous.io](https://nitrous.io/) and signup.
* Everything you need is right here in you browser window - you do not need to start an editor or terminal anywhere else
* If you are following a guide or tutorial, use the commands for Linux even if you are on a Windows computer - your operating system does not matter, since all commands are run on your project's machine in the cloud, which is running Linux
* If a guide or tutorial asks you to start the rails server with 'rails server' or 'rails s', append '-b 0.0.0.0' to this command so that you run 'rails server -b 0.0.0.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide usually formats terminal commands using backticks. For consistency, I suggest to use backticks instead of single quotes for rails server, rails s etc in the previous list item.

@sssggr
Copy link
Member Author

sssggr commented Nov 22, 2016

@titanoboa, thanks! Adjusted accordingly.

@titanoboa titanoboa merged commit c9e8db3 into railsgirls:master Nov 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants