Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend README with a Dynamic Facebook Pixel Options example #108

Closed
simonknoll opened this issue Apr 10, 2018 · 3 comments
Closed

Extend README with a Dynamic Facebook Pixel Options example #108

simonknoll opened this issue Apr 10, 2018 · 3 comments

Comments

@simonknoll
Copy link

Would it be possible to add an example on how to use the following feature
#101
I've tried to take advantage of this feature but I keep failing. How should the lambda be passed to the config/initializer?

@bumi
Copy link
Contributor

bumi commented Apr 10, 2018

what did you try?

maybe these examples help:
user id example for google: https://github.com/railslove/rack-tracker#google-analytics
in the test: https://github.com/railslove/rack-tracker/blob/master/spec/handler/facebook_pixel_spec.rb#L24

but indeed an example - simar to the ones for the other trackers - would be helpful. maybe I can help you get it running and you can make a pull request for that?

@simonknoll
Copy link
Author

I managed to get it working. Thanks. I've created a pull request.

@bumi
Copy link
Contributor

bumi commented Apr 11, 2018

awesome, happy to hear that it worked and thanks for the pull request to improve the readme on this.
I will look at it tomorrow.

@bumi bumi closed this as completed Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants