Skip to content
This repository has been archived by the owner on May 21, 2019. It is now read-only.

Smart Ctrl+C #1115

Open
vlad-shatskyi opened this issue Jul 14, 2017 · 6 comments
Open

Smart Ctrl+C #1115

vlad-shatskyi opened this issue Jul 14, 2017 · 6 comments
Labels

Comments

@vlad-shatskyi
Copy link
Contributor

On Linux, Ctrl+C should copy text if there exists selection, otherwise it should send SIGINT to the current command.

@SRGOM
Copy link

SRGOM commented Jul 14, 2017

Some may not like this, I think you should have the standard C-S-c and C-S-v for copy and paste. C-c and C-v should be for interrupt and next-key-verbatim only. Just my two cents.

@vlad-shatskyi
Copy link
Contributor Author

vlad-shatskyi commented Jul 15, 2017

As usual, please vote. My reasoning is that

  • Copying and pasting are more frequently used actions and deserve simpler shortcuts.
  • It’s consistent with other applications.

@SRGOM
Copy link

SRGOM commented Jul 15, 2017

I like your reasoning but I'd be against making them smart, is it okay to pop a message first time user presses C-c that interrupt is C-S-c? I don't want the situation where a program was interrupted because my selection was messed.

@vlad-shatskyi
Copy link
Contributor Author

@SRGOM good point, inconsistent behavior can cause mistakes. What do you think if we always copy on Ctrl+C and interrupt on double Ctrl+C press?

@SRGOM
Copy link

SRGOM commented Jul 17, 2017

That does sound a good middle path. On that note- I'm assuming you're doing this as a default behavior and your code actually reads from a config file a list of keystrokes/chords to map to actions? In which case C-c-c for interrupt sounds like a better default. If someone is "power user" enough to need C-c at it's original place, they'd be enough "power user" to edit config!

@deckar01
Copy link

deckar01 commented Jan 16, 2018

The context menu says Ctrl+C is Copy, but it doesn't work.

screenshot_2018-01-16_15-49-30


A context sensitive Ctrl+C binding seems like a nice compromise. Ctrl+Shift+C is working great for me now, but I switch back and forth between a mac and linux so it trips me up often. I actually use a mac keyboard on linux with Super mapped to Ctrl.

I would rather deprecate the Ctrl+C interrupt in favor of a modern UI solution like a red button that says "Stop".

screenshot_2018-01-16_16-09-44

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants