Skip to content
This repository has been archived by the owner on May 21, 2019. It is now read-only.

Enter key does not work #364

Closed
corymickelson opened this issue May 23, 2016 · 5 comments
Closed

Enter key does not work #364

corymickelson opened this issue May 23, 2016 · 5 comments

Comments

@corymickelson
Copy link

Just installed. Terminal opens, can type into terminal but enter does nothing.

@jredville
Copy link

I ran into this as well and opened up the dev tools. Discovered the following error on every keypress. Happy to provide any info needed to help debug or repro

/Users/jdeville/proj/black-screen/compiled/src/views/4_PromptComponent.js:5 Uncaught (in promise) Can't parse alias line:     && bundle package \rejected @ /Users/jdeville/proj/black-screen/compiled/src/views/4_PromptComponent.js:5

@sammous
Copy link

sammous commented May 24, 2016

Same is happening to me, enter key does not work.
This error pops up:
screenshot 2016-05-24_09-28-45

@lazywithclass
Copy link

lazywithclass commented May 24, 2016

It seems to me that the problem is here: https://github.com/shockone/black-screen/blob/master/src/Aliases.ts#L15

If you try to comment https://github.com/shockone/black-screen/blob/master/src/Aliases.ts#L27 it should work. I might be really wrong here but my assumption as newbie of this project (I discovered this a couple hours ago), is that it assumes lines to be an Array composed by = separated Strings.
In my case it's not, so goes into the else branch and throws.

EDIT:

After having a look at it in more detail I've seen that after this line https://github.com/shockone/black-screen/blob/master/src/PTY.ts#L83 this is the command that gets executed in my case

/bin/zsh -c 'source /Users/lazywithclass/.zshrc; alias'

the problem with this is that I have some echoed messaged that are printed to stdout when creating a new shell, so these are considered as aliases, thus giving the error.

@ShockOne what's the reasoning behind sourceing the shell config file?

@vlad-shatskyi
Copy link
Contributor

@lazywithclass to import all your aliases.

@lazywithclass
Copy link

I see. I still had those even without the sourceing though... but I'm probably missing something. Thanks for this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants