Skip to content
This repository has been archived by the owner on May 21, 2019. It is now read-only.

No need to add node_modules to path #51

Closed
markogresak opened this issue Sep 7, 2015 · 2 comments
Closed

No need to add node_modules to path #51

markogresak opened this issue Sep 7, 2015 · 2 comments

Comments

@markogresak
Copy link

In package.json, you're adding node_modules/.bin to path. This is not required, since npm run [script] will automatically try to find the binaries in .bin folder.

@iiegor
Copy link
Contributor

iiegor commented Sep 7, 2015

+1

I think the entire PATH=node_modules/.bin:$PATH rm -rf node_modules is unnecesary and also makes windows users can't be able to run the script.

@markogresak
Copy link
Author

Using rm -rf is the least of problems that make it unusable on Windows. If you look at the source, it's assuming *nix architecture so making it work on windows would require major refactoring.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants