notifications: general marketing #5206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Taking a look after expo meeting |
ibrahimtaveras00
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Looked good on Android as well, QA Passed ✅
https://github.com/rainbow-me/rainbow/assets/41752922/f44b8ff7-55db-46cc-9035-1bdd495518a3
also did a check on notifications from WC and mainnet txns 👍🏽
benisgold
approved these changes
Dec 2, 2023
| logger.info(`NotificationsHandler: handling marketing notification`, { | ||
| notification, | ||
| }); | ||
| const data = (notification.data as unknown) as MarketingNotificationData; |
There was a problem hiding this comment.
idk what double type casting does but just noting it in case its not necessary
There was a problem hiding this comment.
can't cast it to MarketingNotificationData without casting to unknown first, TS bs
BrodyHughes
added a commit
that referenced
this pull request
Dec 6, 2023
…brody/QR-code-scanner-fixes * 'develop' of https://github.com/rainbow-me/rainbow: notifications: general marketing (#5206) [APP-946]: Fixes swap input currencylist value bug (#5221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-934
What changed (plus any additional context for devs)
added simple handling for marketing focused notifications, we already technically had support for them but now it allows us to navigate to different screens
Screen recordings / screenshots
https://cloud.skylarbarrera.com/RPReplay_Final1701273411.MP4
What to test
android, can't build locally atm 😮💨