Expo support #5223
Closed
Expo support #5223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* android changes * refresh lock file
This reverts commit 89181ef.
dereknelson
force-pushed
the
@derek/expo-patches
branch
from
c0a0501
to
c2da317
Compare
|
undid sentry expo. no errors happening & successful source maps upload |
ibrahimtaveras00
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Ran https://www.notion.so/rainbowdotme/Critical-Path-Checklist-a907ffa19e854e5492fcefd2bf79f8cd regression on both OS's and everything looks gucci ✅
Co-authored-by: Matthew Wall <matthew.wallt@gmail.com>
|
@SocketSecurity ignore npm/esbuild@0.11.23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-838
What changed (plus any additional context for devs)
This PR adds support for Expo builds. Because of the changes made to the build process, we should consider our other build process legacy at this point.
Checklist before reviewing
RAINBOW_SCRIPTS_TOKEN=github_xxxxxxxxto .env from 1passyarn nuke && yarn fasteas login(reach out if you need access to the expo project)To trigger a development build
Depending on what platform you want to build, you can run
yarn eas-build:devfor both platforms.yarn eas-build:dev:<PLATFORM>for a specific platform. (e.g. -yarn eas-build:dev:ios)Screen recordings / screenshots
Nothing to really screenshot / show here as this is more of a DX / internal improvement
What to test
There's quite a bit we want to test here before we should consider this mergable. We'll probably want to do a group bug bash session to see if anything funky comes up.