-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] connect modal not showing custom wallet button #1903
Comments
@technophile-04 Creating wallets in v2 is kind of complicated, but if you look at this We're looking to simplify wallet creation process, but for now can you go for that approach ? |
Thanks @magiziz !! Just tried it out and works like a charm !
Nice, Thanks !! Some small suggestions:
^ lol not sure if the above things makes sense, since I don't have over all context so please feel free to ignore it If anyone in future stumbled upon this or needs help with custom wallet you can find a naive example here : https://github.com/technophile-04/rainbowkit/pull/1/files Thanks @magiziz again ! Please feel free to close this issue 🙌 |
@technophile-04 Glad it worked out. Yeah we also have a PR opened here and we'll make sure to make it simpler for users to create wallets 🙏 |
Closing this issue since for now since we're going to deprecate EIP-1193. |
Is there an existing issue for this?
RainbowKit Version
^2.0.4
wagmi Version
^2.5.11
Current Behavior
The custom wallet button is not rendered inside connect modal when having custom connector + custom wallet.
Expected Behavior
Similar to rainbowkit v1 it should render custom wallet button in connect modal.
Steps To Reproduce
For easy debuggin and MRR, I have just forked this rainbowkit repo and added our custom connector to
packages/examples
dir. It has very minimal changes, checkout the file changes here => https://github.com/technophile-04/rainbowkit/pull/1/filesSteps to setup :
Steps to reproduce :
Example Video :
Screen.Recording.2024-04-01.at.3.02.50.PM.mov
Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
https://github.com/technophile-04/rainbowkit/pull/1/files
Anything else?
Context :
We have been trying to migrate from wagmi v1 => v2 in scaffold-eth/scaffold-eth-2#700, everything works fine with burner wallet being connected and making transactions also no TS errors.
But when you disconnect and try to connect, the burner wallet button does not show up in connect modal
The text was updated successfully, but these errors were encountered: