Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Touchpad zoom and pan do not work on modals #1990

Closed
1 task done
hexcowboy opened this issue May 21, 2024 · 3 comments
Closed
1 task done

[bug] Touchpad zoom and pan do not work on modals #1990

hexcowboy opened this issue May 21, 2024 · 3 comments

Comments

@hexcowboy
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

RainbowKit Version

2.1.0

wagmi Version

N/A

Current Behavior

Modals in RainbowKit do not allow zooming or panning when a modal is open.

Expected Behavior

Modals should allow for zooming or panning using a touchscreen on touch devices or a touch trackpad.

Steps To Reproduce

  1. Open a modal on a touchscreen device or a device with a touchpad
  2. Try zooming by pinching your fingers

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

No response

Anything else?

No response

@DanielSinclair
Copy link
Contributor

@hexcowboy This was actually a design choice that felt appropriate on mobile. Is there a particular issue your seeing that requires pan and zoom, or a usability problem with this behavior?

@hexcowboy
Copy link
Author

hexcowboy commented May 21, 2024

ah, i see. i think the main issue here is accessibility, and you can read a bit more about what the WCAG says about this specific issue

i quite frequently zoom using my touchpad on my macbook to be able to read things on my screen, so i assumed it was a bug

@magiziz
Copy link
Contributor

magiziz commented May 22, 2024

@hexcowboy We're going to close this issue since this was a part of our design choice. Feel free to raise another issue if you find any other bugs. Otherwise thanks for raising the PR 👍

@magiziz magiziz closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants