Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The koin project's maven group id has changed #34

Closed
wants to merge 2 commits into from

Conversation

Benjiko99
Copy link

@Benjiko99 Benjiko99 commented Jun 6, 2021

The koin project's maven group id was previously org.koin and is now io.insert-koin.
Also, the jcenter() repository is being shut down so I've removed it.

Reference: github.com/InsertKoinIO

@Benjiko99 Benjiko99 closed this Jun 8, 2021
@Benjiko99 Benjiko99 deleted the koin_new_group_id branch June 8, 2021 16:41
@Benjiko99 Benjiko99 restored the koin_new_group_id branch June 8, 2021 16:41
@zsmb13
Copy link
Member

zsmb13 commented Jun 8, 2021

Hi @Benjiko99, did this somehow get resolved since you opened the PR, or is an update still needed? I just got around to this.

@Benjiko99
Copy link
Author

Benjiko99 commented Jun 8, 2021

@zsmb13 I'm unsure whether it would be a breaking change and require migration from consumers of the library, as they would probably be required to also change the dependencies in their own project and the imports in the code. Nevertheless, this will have to be done soon, because mavenCentral only hosts the new group id and jcenter is shutting down.

@zsmb13
Copy link
Member

zsmb13 commented Jun 9, 2021

Will be included in 1.4.0, which is being prepared here #35

@Benjiko99
Copy link
Author

Tight 😎

@Benjiko99 Benjiko99 deleted the koin_new_group_id branch June 9, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants