Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncu -ws --root -i is not working in pnpm workspaces. #1196

Closed
3 tasks done
imguolao opened this issue Sep 28, 2022 · 2 comments · Fixed by #1197
Closed
3 tasks done

ncu -ws --root -i is not working in pnpm workspaces. #1196

imguolao opened this issue Sep 28, 2022 · 2 comments · Fixed by #1197

Comments

@imguolao
Copy link
Contributor

imguolao commented Sep 28, 2022

  • I have searched for similar issues
  • I am using the latest version of npm-check-updates
  • I am using node >= 14

Steps to Reproduce

See this repo: https://github.com/imguolao/ncu-pnpm-workspaces

Current Behavior

Only working in the root.

image

No anything hanppen.

image

os: windows 10
node: v18.2.0
ncu@version: 16.3.2

Expected Behavior

@raineorshine
Copy link
Owner

raineorshine commented Sep 28, 2022

I'm not able to reproduce (on OSX) unfortunately:

raine[ncu-pnpm-workspaces]% npx ncu -ws
Checking /Users/raine/projects/ncu-pnpm-workspaces/packages/one/package.json
[====================] 1/1 100%

 vue  2.6.14  →  3.2.40

Run npx ncu -ws -u to upgrade packages/one/package.json
Checking /Users/raine/projects/ncu-pnpm-workspaces/packages/two/package.json
[====================] 1/1 100%

 vue  2.6.14  →  3.2.40

Run npx ncu -ws -u to upgrade packages/two/package.json

@imguolao
Copy link
Contributor Author

imguolao commented Sep 29, 2022

You should convert all path to posix path for glob match, but there are two places that are not converted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants