Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore github dependencies #12

Closed
silverwind opened this issue Feb 25, 2014 · 3 comments
Closed

Ignore github dependencies #12

silverwind opened this issue Feb 25, 2014 · 3 comments
Assignees
@raineorshine
Labels
bug
Milestone
v2

Comments

@silverwind
Copy link

My package.json has

    "codemirror": "marijnh/CodeMirror.git#v4"

When running npm-check-updates -u it seems to want to downgrade me to the latest relase, on a nonexistant branch:

"codemirror" can be updated from marijnh/CodeMirror.git#v4 to marijnh/CodeMirror.git#v3 (Installed: 4.0.0, Latest: 3.22.0)

Shortly after, I get

npm ERR! notarget No compatible version found: codemirror@'marijnh/CodeMirror.git#v3'
npm ERR! notarget Valid install targets:
npm ERR! notarget ["2.33.0","3.14.1","3.15.0","3.16.0","3.17.0","3.18.0","3.19.0","3.20.0","3.21.0","3.22.0","3.11.1","3.12.0","3.13.0"]

CodeMirror right now only has these branches: v4, v2, master.
silverwind referenced this issue in silverwind/droppy Feb 25, 2014
@silverwind
Pull CodeMirror in through package.json
5899a8b
@raineorshine
Copy link
Owner

Yes, it seems that the version parser doesn't handle github url's properly. Should be looked into.

@raineorshine raineorshine changed the title git dependency check doesn't seem to stay on the branch Breaks on github dependencies that don't specify the full url Feb 18, 2015
@raineorshine raineorshine added this to the 2.0.0 milestone May 22, 2015
@raineorshine raineorshine self-assigned this May 22, 2015
@raineorshine raineorshine changed the title Breaks on github dependencies that don't specify the full url Ignore github dependencies May 22, 2015
This was referenced May 22, 2015
Closed
Closed
Closed
@raineorshine
Copy link
Owner

Version patterns to ignore:

  • git://github.com:RichardLitt/rangy.git#748582f
  • RichardLitt/rangy.git
  • git+ssh://git@bitbucket.org:org/project

@raineorshine
Copy link
Owner

Fixed in v2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raineorshine raineorshine

Labels
bug
Projects
None yet
Milestone
v2
Development

No branches or pull requests
2 participants
@silverwind @raineorshine