Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New users dashboard widget #343

Closed
scottbedard opened this issue Jul 23, 2018 · 7 comments
Closed

New users dashboard widget #343

scottbedard opened this issue Jul 23, 2018 · 7 comments

Comments

@scottbedard
Copy link
Contributor

scottbedard commented Jul 23, 2018

I'd like to add a dashboard widget to this plugin. The widget I'd like to add will show the number of users that have signed up this day, week, month, or year. It would also show the number of users who signed up in the previous day, week, month, or year.

I plan to make it look like the "Comments" section in our scoreboard example...
https://octobercms.com/docs/ui/scoreboard

If this is acceptable, I'll get started on the PR.

@scottbedard scottbedard changed the title Dashboard widgets New users dashboard widget Jul 23, 2018
@LukeTowers
Copy link
Contributor

Sure, go for it @scottbedard! Prefer no new tables though.

@scottbedard
Copy link
Contributor Author

scottbedard commented Jul 24, 2018

@LukeTowers are you still against merging this?
master...scottbedard:master

Right now I'm having to maintain this fork in order to use this plugin, and github will only let me fork a repo once. I'd happily do this work off the same fork if you're willing to accept those safer migrations. If not, I'll have to make a second account or something to do this work. Also, has there been any movement on #328? I'd like to be able to write tests as I do this, but I suppose I could do it without them if I have to.

@LukeTowers
Copy link
Contributor

@scottbedard no, I've gone ahead and merged it. I would still prefer a cleaner solution that fixes testing for all plugins without having to do the hasColumn workaround but it is acceptable for now.

Could you make the travis config for #328 more similar to https://github.com/octobercms/october/blob/master/.travis.yml or provide recommendations on what an ideal base travis config for setting up testing for all plugins would be?

@scottbedard
Copy link
Contributor Author

Wooo! Thank you for merging that for me, that is going to make it so much easier to integrate this plugin with my projects. With regard to the .travis.yml file, I can try to simplify it a bit, but I won't be able to get it as minimal as the one for the core October repo. Plugin tests need to have an October instance installed around them in order for things to work.

Regardless though, I'll see what I can do, and I'll get started on this PR. Thanks again!

@LukeTowers
Copy link
Contributor

Sounds good!

@scottbedard
Copy link
Contributor Author

Here are a couple of screenshots
horizontal
properties

@scottbedard
Copy link
Contributor Author

I'm closing this issue due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants