Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

Limit to node v17.x #2

Closed
bengreenier opened this issue Jan 4, 2022 · 1 comment · Fixed by #3, #10, #17, #41 or #49
Closed

Limit to node v17.x #2

bengreenier opened this issue Jan 4, 2022 · 1 comment · Fixed by #3, #10, #17, #41 or #49
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@bengreenier
Copy link
Contributor

Seems we need a v17 node version that includes nodejs/node#33321 - otherwise we crash (ex: https://github.com/RainwayApp/node-clangffi/runs/4707348089?check_suite_focus=true)

We should include engines in package.json to clarify this.
@bengreenier bengreenier added bug Something isn't working good first issue Good for newcomers labels Jan 4, 2022
bengreenier added a commit that referenced this issue Jan 4, 2022
@bengreenier
feat(engines): Add engines field
bac680c 
fixes #2
@bengreenier bengreenier mentioned this issue Jan 4, 2022
Merged
@bengreenier
Copy link
Contributor Author

Related discussion: node-ffi-napi/ref-napi#54

bengreenier added a commit that referenced this issue Jan 4, 2022
@bengreenier
feat(engines): Add engines field (#3)
2c5b4a8 
fixes #2
This was referenced Jan 5, 2022
Closed
Merged
This was referenced Jan 5, 2022
Merged
Closed
Merged
@github-actions github-actions bot mentioned this issue Mar 15, 2022
Merged
This was referenced Mar 24, 2022
Merged
Merged
@github-actions github-actions bot mentioned this issue Apr 5, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
1 participant
@bengreenier