Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #remote_find_by #34

Merged
merged 5 commits into from Feb 24, 2021
Merged

Add #remote_find_by #34

merged 5 commits into from Feb 24, 2021

Conversation

boardfish
Copy link
Owner

Defaults to remote_where().first if not defined.

We should also implement and test #remote_find_by!, but whether that gets done now or later is up for discussion.

johndbritton
johndbritton approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@johndbritton johndbritton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main feedback:

  1. Move these methods under a namespace, for example remote
  2. Make the namespace configurable
  3. In the future move behavior related client / service dependency and lookup into an adapter concept

lib/remote_record/reference.rb Show resolved Hide resolved
@boardfish boardfish mentioned this pull request Feb 24, 2021
Closed
@boardfish boardfish merged commit 8dd1cff into main Feb 24, 2021
@boardfish boardfish deleted the remote-find-by branch February 24, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johndbritton johndbritton johndbritton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boardfish @johndbritton