Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support to title on iOS #322

Merged
merged 1 commit into from
Nov 22, 2017
Merged

feat: add support to title on iOS #322

merged 1 commit into from
Nov 22, 2017

Conversation

sampaiodiego
Copy link
Contributor

According to Apple's docs the prefered type for alert is a dictionary, tha's why I changed it to have a body field.

And this also allowed me to add a title for the notification, which has support since iOS 8.2.

@sampaiodiego sampaiodiego mentioned this pull request Nov 20, 2017
Merged
@rodrigok rodrigok mentioned this pull request Nov 22, 2017
Merged
@rodrigok rodrigok changed the title Add support to title on iOS feat: add support to title on iOS Nov 22, 2017
@rodrigok rodrigok merged commit b49487a into Meteor-Community-Packages:master Nov 22, 2017
@rodrigok rodrigok deleted the add-support-to-title-in-ios branch November 22, 2017 23:59
@raix
Copy link
Collaborator

raix commented Nov 23, 2017

@rodrigok if the pr doesn't trigger a release one workaround for now would be to commit changes to the CHANGELOG.md - ex.: 1b75a69 - It's not ideal - but it would allow you to release.

I'll push forward solving the issue why merge requests are not parsed correctly by semantic-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sampaiodiego @raix @rodrigok