Refactor based on flutter_lints
#11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myConsciousness
commented
Apr 23, 2022
| @@ -125,13 +125,20 @@ class SideMenu extends StatefulWidget { | |||
| bool get inverse => _inverse == -1; | |||
|
|
|||
| @override | |||
| // ignore: no_logic_in_create_state | |||
There was a problem hiding this comment.
However, this line was the only one I could not refactor in my judgment, so I added a definition that ignores the warning for the moment.
The createState method should not have processing, so the timing for generating each of these States must be adjusted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi amazing developer,
This library is already a great completion, but I have noticed that some of the coding does not follow Dart or Flutter standards because it does not use flutter_lints.
Therefore, I have made the following fixes.
flutter_lintstopubspec.yamlanalysis_options.yamlflutter_lintssuggestions (Not destructive)Thank you.