Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): Dracula Config warning #203

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

mesalilac
Copy link
Contributor

bar has been deprecated; use colors.footer_bar instead

@mesalilac mesalilac changed the title fix: Config warning fix(theme): Config warning Nov 21, 2022
@mesalilac mesalilac changed the title fix(theme): Config warning fix(theme): Dracula Config warning Nov 21, 2022
@JuanVqz
Copy link
Collaborator

JuanVqz commented Nov 21, 2022

hey @Senpai-10 thank you for fixing it, couple of questions:

  • do you have a link or where can we see the deprecation warning, could you please share it here? (just in case we need it as a reference)
  • Did you check all themes to confirm only Dracula is using it? if not, could you please check it?

Btw, this theme was taken from this repo probably they need the fix as well.

Thanks! 🚀

@mesalilac
Copy link
Contributor Author

mesalilac commented Nov 22, 2022

do you have a link or where can we see the deprecation warning, could you please share it here? (just in case we need it as a reference)

https://github.com/alacritty/alacritty/blob/694a52bcffeffdc9e163818c3b2ac5c39e26f1ef/alacritty/src/config/color.rs#L129-L130

Did you check all themes to confirm only Dracula is using it? if not, could you please check it?

Yes I did 👍

Btw, this theme was taken from this repo probably they need the fix as well.

Thank you, I'm going to fix it there too it's already fixed in repo :)

@JuanVqz
Copy link
Collaborator

JuanVqz commented Nov 23, 2022

it seems like it is not correctly aligned though https://github.com/dracula/alacritty/blob/master/dracula.yml#L28

Copy link
Collaborator

@JuanVqz JuanVqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Senpai-10 Thanks!

@JuanVqz JuanVqz merged commit cda1555 into rajasegar:master Nov 23, 2022
github-actions bot pushed a commit that referenced this pull request Nov 23, 2022
## [5.3.1](v5.3.0...v5.3.1) (2022-11-23)

### Bug Fixes

* Config warning: bar has been deprecated; use `colors.footer_bar` instead ([#203](#203)) ([cda1555](cda1555))
@rajasegar
Copy link
Owner

🎉 This PR is included in version 5.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mesalilac mesalilac deleted the fix-bar-deprecated branch November 23, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants