Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom krew index #47

Open
tamalsaha opened this issue Oct 9, 2020 · 8 comments
Open

Support custom krew index #47

tamalsaha opened this issue Oct 9, 2020 · 8 comments

Comments

@tamalsaha
Copy link

tamalsaha commented Oct 9, 2020

Thanks for this bot. We are looking to use this bot with our hosted custom plugin index.
ref: https://krew.sigs.k8s.io/docs/developer-guide/custom-indexes/

Is that possible? If not, could that be supported?

@rajatjindal
Copy link
Owner

hey @tamalsaha , thanks for reaching out. I follow/admire your work on a lot of kubernetes related projects, so it means a lot to hear from you.

the custom index support should be already supported (you can override the default krew-index org/repo using env variables). could you please try that once?

also seems like the url you provided is not for the custom krew-index right?

in the meantime, i would give this a try too, and revert back.

@rajatjindal
Copy link
Owner

ok, i looked at the code, its on server side where u can use env variable to override the krew-index org/repo. I will explore making change to be able to override them from client side (github-action), and report back.

@tamalsaha
Copy link
Author

Thanks for the kind words, @rajatjindal ! This work also looks very impressive.

We have decided to extend our existing release automation process to also update the krew manifest, instead of using this action. I did use your idea to use a krew.yaml template. Sorry taking up your time.

@rajatjindal
Copy link
Owner

Sure, thanks.

I will keep this ticket open to add the support incase anyone else needs that in future

Thanks again

@ArtemTrofimushkin
Copy link

hello @rajatjindal !
is there any updates on this issue?

@rajatjindal
Copy link
Owner

Hi @ArtemTrofimushkin

I haven't had chance to look at this yet. I will try to spend some time on this next week. (or may be you can submit as a PR?)

thanks

@ArtemTrofimushkin
Copy link

Thanks!
I will submit PR in a few days!

@ankishagarwal
Copy link

@ArtemTrofimushkin Were you able to work on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants