Today button not working

[alexandretok]

The today button doesn't work when I have the option closeOnSelect: true.

The callback isn't fired and the calendar just closes. I can see that the today date is highlighted right before the calendar fades.

[postb99]

I've fixed it on my fork but not tagged for now. It fact it was a wrong feature :-)

OSAMES@46f5c6f

[postb99]

Fixed on my fork, version 1.4.0. bower package name is ionic-datepicker-fork-ionic1

My fork : https://github.com/OSAMES/ionic-datepicker

I wish I could do a pull request but since I changed package name etc I don't know how to handle this.

[shankari]

It looks like commits 45631a4 and 0fb4e66 (currently on master) might have also fixed this? Trying now. These are the last two commits merged to master, so just syncing directly to 6dcbf0d which is the merge commit.

[shankari]

Those commits will probably fix the issue, but the distfile has not been rebuilt to include them. I am rebuilding the distfile using gulp. @rajeshwarpatlolla if I submitted a PR with an updated dist file would you be open to merging it?

[shankari]

@postb99 I tried your fork and it still doesn't work. See attached gif. I looked at your code https://github.com/OSAMES/ionic-datepicker/blob/master/src/ionic-datepicker.provider.js#L404 and it looks like the callback is not invoked like in 45631a4

Any thoughts on how your fork is supposed to work?

[postb99]

I am not able to work anymore on this project/my fork, I will close my PR and think you can go on with improvement of official project @shankari