Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build project - Resulting minified file is "broken" #102

Closed
rinogo opened this issue Oct 17, 2016 · 3 comments
Closed

Can't build project - Resulting minified file is "broken" #102

rinogo opened this issue Oct 17, 2016 · 3 comments

Comments

@rinogo
Copy link

rinogo commented Oct 17, 2016

gulp build doesn't work quite right. It executes without errors, but the resulting minified file does not function correctly. (I get an error in my web browser about the template not being loaded)

The problem is that for some reason, the ionic-timepicker.templates dependency is not being injected. This explains why the template can't be loaded. To get around this problem, I simply build the project and then manually insert the ionic-timepicker.templates dependency in the minified file. This works, but is a bit of a nuisance, especially for other devs who might not be savvy enough to determine what is wrong.

How can this be fixed?

@rinogo rinogo changed the title Can't build project - Minified file is "broken" Can't build project - Resulting minified file is "broken" Oct 17, 2016
@fonini
Copy link

fonini commented Oct 17, 2016

The error is ionic-timepicker/src/ionic-timepicker.module.js. You have to uncomment the 'ionic-timepicker.templates' line and build again.

@rajeshwarpatlolla Any chance to get this fixed? Thanks!

@rajeshwarpatlolla
Copy link
Owner

Yes you are right. You need to uncomment in order to build it.

@rinogo
Copy link
Author

rinogo commented Oct 17, 2016

Ha! I can't believe I missed that. Thanks, @fonini, and @rajeshwarpatlolla.

Should I submit a PR, @rajeshwarpatlolla?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants