-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"shell" is not supported #19
Comments
Reading your code, I saw you're using Prism highlighter by default // https://github.com/rajinwonderland/react-code-blocks/blob/master/packages/react-code-blocks/src/components/Code.tsx#L2
import React, { PureComponent } from 'react';
import { PrismAsyncLight as SyntaxHighlighter } from 'react-syntax-highlighter';
import { applyTheme } from '../utils/themeBuilder'; And you normalized the bash to shell // https://github.com/rajinwonderland/react-code-blocks/blob/master/packages/react-code-blocks/src/utils/normalizeLanguage.ts#L67-L70
{
name: 'Shell',
alias: ['shell', 'bash', 'sh', 'ksh', 'zsh'],
value: 'shell',
}, And then I checkout the react-syntax-highlighter It looks like Prism support bash instead of shell. |
Great catch @lawrenceching I'll go ahead and fix this! |
Is this fixed? I'm still getting the error. |
I'm getting the same error but with |
@SebasG22 try using @thesobercoder @lawrenceching I'll be hopefully free this weekend to push a new release! 🤞 Always accepting PRs too! |
Hi @rajinwonderland, I tried this weekend to push a PR to you to fix it, but I was unable to fork the repo and make it worked on my laptop. For example, I had some trouble with the command |
Hey @mat250 sorry for answering so late! You want to: Install Dependenciesyarn Start Storybookyarn pkg storybook Build the Packageyarn pkg build Watch the package
Preview on Demoyarn start:demo or yarn demo start Submit PR🎉🎉🎉🎉 Let me know if this helps! |
This issue still occurs in version 0.0.8 published in npm. |
Hi
I saw the shell is supported in this page:
https://github.com/rajinwonderland/react-code-blocks/blob/master/LANGUAGES.md
But it gave me this error
"bash" is working ok.
Would it be a typo in the document?
Where is the gold source of all supported language list?
Thanks in advanced
The text was updated successfully, but these errors were encountered: