Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation note for deletion #31

Open
rajivsarvepalli opened this issue Jan 14, 2021 · 0 comments
Open

Add documentation note for deletion #31

rajivsarvepalli opened this issue Jan 14, 2021 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@rajivsarvepalli
Copy link
Owner

Added documentation note saying keywords can be added to delete with no impact. Some note like:

You can use keywords with delete like so:

n_d = s.query(Data).filter(Data.data_p1 >= 13).delete(synchronize_session=False)

and this will work. However, the keyword arguments have no impact on the delete command, but merely are allowed so as little code as possible has to be changed. However, delete cannot be used with objects such as:

a = Data(pk1=11, data_p1=31.5, data_p2=67.1, name="test13")
n_d = s.delete(a)

The above code is invalid when using UnifiedAlchemyMagicMock as the session object s.

@rajivsarvepalli rajivsarvepalli added the documentation Improvements or additions to documentation label Jan 14, 2021
@rajivsarvepalli rajivsarvepalli added this to the 0.1.1 Release milestone Jan 14, 2021
@rajivsarvepalli rajivsarvepalli changed the title Added documentation note for deletion Add documentation note for deletion Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant