Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider Blocking session.close() #32

Open
rajivsarvepalli opened this issue Jan 19, 2021 · 0 comments
Open

Consider Blocking session.close() #32

rajivsarvepalli opened this issue Jan 19, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@rajivsarvepalli
Copy link
Owner

Currently session.close() should close off the session, however maybe this is undesired behavior. In many test cases, this session object will be passed to other functions which may close the session. This makes checking the session for the correct additions/deletions harder since you need to make sure not close the session while testing inside functions. If the UnifiedAlchemyMagicMock is the session being used maybe closing the session.close() is obnoxious to deal with. Maybe some other command could close the session?

@rajivsarvepalli rajivsarvepalli added the enhancement New feature or request label Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant