Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default_chmod parameter. ( See #220 ) #243

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Conversation

Jakiboy
Copy link
Contributor

@Jakiboy Jakiboy commented Oct 4, 2022

New ability to define Default chmod instead of 0777. ( See #220 )

Timu57 and others added 2 commits September 28, 2022 02:44
@Timu57
Copy link
Member

Timu57 commented Oct 7, 2022

Hi @Jakiboy sorry for the late response and thank you very much for your contribution 😍 I really appreciate that.
The code you wrote looks great 👍
I just found one thing that could/ should be improved. I am currently a little bit busy, that's why I ask you if you could do the change. If not I will do it when I have time.
You called the configuration and parameter default_chmod and defaultChmod. But the permissions set are just used to create the folders if they don't exist. Could you change the naming to something more specific like for example folder_permissions. Then I can update the documentation accordingly and merge your request.
Thank you in advance 😊

@Jakiboy
Copy link
Contributor Author

Jakiboy commented Oct 7, 2022

Hi @Timu57, Thankyou for your response, i'll do this change right now.
Thanks.

New ability to define Default folder permissions instead of 0777. ( See SleekDB#220 )
@Jakiboy Jakiboy marked this pull request as draft October 7, 2022 18:30
@Jakiboy Jakiboy marked this pull request as ready for review October 7, 2022 18:32
@Timu57 Timu57 merged commit 156567e into SleekDB:dev Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants