Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sktime integration of data_loader.convert_tsf_to_dataframe #7

Closed
fkiraly opened this issue Dec 17, 2021 · 5 comments
Closed

sktime integration of data_loader.convert_tsf_to_dataframe #7

fkiraly opened this issue Dec 17, 2021 · 5 comments

Comments

@fkiraly
Copy link

fkiraly commented Dec 17, 2021

Really nice collection of forecasting benchmark datasets you have here!

We were wondering (at sktime) whether you would be open for us to integrate (a possibly modified) data_loader.convert_tsf_to_dataframe into the data_io module of sktime, using the Monash forecasting repository as a data endpoint. Of course with proper attribution and crediting of the source.

Since tsf is based on the ts format and the loaders are similar, it would fit nicely with a current refactoring effort in the space.

If you'd be up for a chat and/or collaboration, feel free to visit us on the sktime slack, forecasting or forecasting-global channel.
(go https://github.com/alan-turing-institute/sktime, README -> slack badge at the top)
Might also be nice to collaborate on "nice" benchmark functionality, which can be loaded as a package and which directly interfaces with existing base class templates (with no need to write extra glue code that's special to the benchmark)

@fkiraly
Copy link
Author

fkiraly commented Dec 17, 2021

(I assume the code is mainly yours, @rakshitha123?)

@fkiraly
Copy link
Author

fkiraly commented Dec 17, 2021

FYI sktime collaborators, @ltsaprounis, @danbartl, @aiwalter, @satya-pattnaik

@rakshitha123
Copy link
Owner

Hi,

Many thanks for reaching us. Yes, the implementations in this repository were mainly done by me and @pmontman.

We are happy to integrate the .tsf loading functionality into sktime. If it is fine, can you please let us know how we should proceed with that?

@fkiraly
Copy link
Author

fkiraly commented Dec 29, 2021

apologies for the late answer, this is due to Christmas holidays and me checking email less thoroughly.

I'd propose is a call in the new year.
@TonyBagnall is currently refactoring the current data input/output module, so might be best to spend 1h of technical meeting to align on target interfaces once people are back from holiday. ts is very similar to tsf, so it's best to try being consistent?

Before that, I suggest you join the sktime slack and ping @TonyBagnall in the contributors channel, we can have an asynchronous pre-discussion and some introductions there.

@rakshitha123
Copy link
Owner

Many thanks, @fkiraly. Sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants