Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/pod-htmlify.t fails #56

Closed
moritz opened this issue Feb 28, 2015 · 2 comments
Closed

t/pod-htmlify.t fails #56

moritz opened this issue Feb 28, 2015 · 2 comments

Comments

@moritz
Copy link
Collaborator

moritz commented Feb 28, 2015

doc doesn't declare a dependency on Pod::To::HTML or URI because most users don't need to run htmlify. But t/pod-htmlify.t uses Pod::Htmlify, which in turn uses URI::Escape. Which makes the test fail when one tries to install doc via panda, and also in the smoke test

@paultcochrane
Copy link
Contributor

Sorry about that! I've managed to skip t/pod-htmlify.t if URI::Escape isn't installed in ab78bc1, however I'm fairly sure there is an easier way to implement this than the way I used. Any comments or advice as to how to improve the implementation are welcome.

@moritz I've tested on my box that the test runs when expected, however it might be a good idea to confirm this before closing this issue.

@stmuk
Copy link
Contributor

stmuk commented Feb 28, 2015

doc has a dependency on URI but not now on URI::Escape. All tests pass now on both FreeBSD and Linux (Debian Stable) for me with just panda installed so I think this ticket can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants