Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Committable crash #57

Closed
AlexDaniel opened this issue Nov 10, 2016 · 3 comments
Closed

Committable crash #57

AlexDaniel opened this issue Nov 10, 2016 · 3 comments
Labels
committable Issues related to Committable bot

Comments

@AlexDaniel
Copy link
Member

See this: https://irclog.perlgeek.de/perl6/2016-11-10#i_13546322

Here is stdout:

Unhandled exception in code scheduled on thread 19
Unhandled exception in code scheduled on thread 11
Cannot send a message on a closed channel
  in block  at /home/bisectable/git/whateverable/Whateverable.pm6 (Whateverable) line 95
  in any  at /home/bisectable/.rakudobrew/moar-nom/install/share/perl6/runtime/CORE.setting.moarvm line 1
  in sub THROW at /home/bisectable/.rakudobrew/moar-nom/install/share/perl6/runtime/CORE.setting.moarvm line 1

Cannot send a message on a closed channel
  in block  at /home/bisectable/git/whateverable/Whateverable.pm6 (Whateverable) line 96
  in any  at /home/bisectable/.rakudobrew/moar-nom/install/share/perl6/runtime/CORE.setting.moarvm line 1
  in sub THROW at /home/bisectable/.rakudobrew/moar-nom/install/share/perl6/runtime/CORE.setting.moarvm line 1
@AlexDaniel AlexDaniel added the committable Issues related to Committable bot label Nov 10, 2016
@AlexDaniel
Copy link
Member Author

AlexDaniel commented Dec 4, 2016 •
edited
Loading

Does not crash anymore after 3ac4ca3, but prints https://gist.github.com/ instead of a proper link.

@AlexDaniel AlexDaniel mentioned this issue Dec 4, 2016
Closed
@AlexDaniel
Copy link
Member Author

This was because of some control characters, I guess? Fixed now.

@AlexDaniel AlexDaniel added the testneeded Issue is generally resolved but tests were not written yet label Jan 6, 2017
@AlexDaniel
Copy link
Member Author

Not sure how to write a test for this because the original snippet creates an IRC bot (which will soon be disallowed). Therefore, no tests.

@AlexDaniel AlexDaniel removed the testneeded Issue is generally resolved but tests were not written yet label Mar 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
committable Issues related to Committable bot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexDaniel