Skip to content

Commit

Permalink
Ignore shared library versions on OpenBSD.
Browse files Browse the repository at this point in the history
Shared library version numbers in OpenBSD rarely match those provided by
upstream, breaking many packages which specify them.
  • Loading branch information
mornfall committed Dec 8, 2018
1 parent e32ff7e commit 5603128
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/core/VM.pm6
Expand Up @@ -55,6 +55,7 @@ class VM does Systemic {
method platform-library-name(IO::Path $library, Version :$version) {
my int $is-win = Rakudo::Internals.IS-WIN;
my int $is-darwin = self.osname eq 'darwin';
my int $is-openbsd = self.osname eq 'openbsd';

my $basename = $library.basename;
my int $full-path = $library ne $basename;
Expand All @@ -73,7 +74,7 @@ class VM does Systemic {
#?endif

$platform-name ~= '.' ~ $version
if $version.defined and nqp::iseq_i(nqp::add_i($is-darwin,$is-win),0);
if $version.defined and nqp::iseq_i(nqp::add_i(nqp::add_i($is-darwin,$is-win),$is-openbsd),0);

$full-path
?? $dirname.IO.add($platform-name).absolute
Expand Down

1 comment on commit 5603128

@casaca24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. thanks for taking the time and review this. this change allowed NativeLibs module to pass all tests

Please sign in to comment.