Eradicate !=== from the setting

For some reason a !=== a is 5x as slow as !(a === a)
rakudo · Jul 19, 2016 · 6ef9e08 · 6ef9e08
1 parent 649ff44
commit 6ef9e08
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/src/core/Block.pm b/src/core/Block.pm
@@ -288,7 +288,7 @@ my class Block { # declared in BOOTSTRAP
             }
             $p;
         }
-        if ($slurp_n and $slurp_n.capture and $slurp_n !=== $slurp_p) {
+        if ($slurp_n and $slurp_n.capture and !($slurp_n === $slurp_p)) {
             @phash.push(strip_parm($slurp_n));
         }
         my $error = False;

diff --git a/src/core/Stash.pm b/src/core/Stash.pm
@@ -43,9 +43,8 @@ my class Stash { # declared in BOOTSTRAP
     }
 
     method merge-symbols(Stash:D: Hash $globalish) { # NQP gives a Hash, not a Stash
-        if $globalish !=== Stash {
-            nqp::gethllsym('perl6', 'ModuleLoader').merge_globals(self, $globalish);
-        }
+        nqp::gethllsym('perl6','ModuleLoader').merge_globals(self,$globalish)
+          unless $globalish === Stash;
     }
 }
 

diff --git a/src/core/Supply.pm b/src/core/Supply.pm
@@ -619,7 +619,7 @@ my class Supply {
     method unique(Supply:D $self: :&as, :&with, :$expires) {
         supply {
             if $expires {
-                if &with and &with !=== &[===] {
+                if &with and !(&with === &[===]) {
                     my @seen;  # really Mu, but doesn't work in settings
                     my Mu $target;
                     if &as {
@@ -686,7 +686,7 @@ my class Supply {
                 }
             }
             else { # !$!expires
-                if &with and &with !=== &[===] {
+                if &with and !(&with === &[===]) {
                     my @seen;  # really Mu, but doesn't work in settings
                     my Mu $target;
                     if &as {