Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Optimize ADD-ITERATOR-TO-BAG a few percent
For the case where keys already exist in the Bag. This same optimization (using nqp::ifnull(nqp::atkey instead of nqp::if(nqp::existskey...nqp::atkey) could probably be done for *all* the methods in Rakudo/QuantHash Spotted by MasterDuke++
- Loading branch information
Showing
1 changed file
with
18 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c0a556
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this breaks things on the JVM backend. I didn't fully investigate yet, but basic things stopped to work:
Reverting this commit makes the code work again.
7c0a556
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created an issue with a golfed version of the failing code: #4272