Skip to content

Commit

Permalink
Remove needless calls to infix:<,> in [sS]/// codegen
Browse files Browse the repository at this point in the history
After a discussion[^1] and testing the output of old tickets[^2],
it looks like these are no longer needed. After their removal, the
bugs referenced by tickets do not re-appear and stresstest passes.

[1] https://irclog.perlgeek.de/perl6/2016-12-10#i_13717904
[2] https://irclog.perlgeek.de/perl6/2016-12-10#i_13718025
  • Loading branch information
zoffixznet committed Dec 10, 2016
1 parent bfe4abb commit a34f0af
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions src/Perl6/Actions.nqp
Expand Up @@ -7766,8 +7766,7 @@ class Perl6::Actions is HLL::Actions does STDActions {
# ($/,) = $result - We do this so the replacement closure can close
# over the current match.
QAST::Op.new( :op('p6store'),
QAST::Op.new( :op('call'), :name('&infix:<,>'),
QAST::Var.new( :name('$/'), :scope('lexical') ) ),
QAST::Var.new( :name('$/'), :scope('lexical') ),
QAST::Var.new( :name($result), :scope('local') ),
),

Expand Down Expand Up @@ -7830,8 +7829,7 @@ class Perl6::Actions is HLL::Actions does STDActions {
)
) !!
QAST::Op.new( :op('p6store'),
QAST::Op.new( :op('call'), :name('&infix:<,>'),
QAST::Var.new( :name('$/'), :scope('lexical') ) ),
QAST::Var.new( :name('$/'), :scope('lexical') ),
QAST::Var.new( :name($result), :scope('local') )
)
) !! QAST::Stmt.new(),
Expand Down

0 comments on commit a34f0af

Please sign in to comment.