Merge pull request #1682 from MasterDuke17/micro_optimize_Lists_roll

Micro-optimize List.roll($n)
rakudo · Apr 2, 2018 · f1b9c7d · f1b9c7d
2 parents 111f67a + c71ff66
commit f1b9c7d
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/core/List.pm6 b/src/core/List.pm6
@@ -1077,11 +1077,15 @@ my class List does Iterable does Positional { # declared in BOOTSTRAP
                          }
                      }
                      method push-all($target --> IterationEnd) {
-                         nqp::while(
-                             $!todo,
-                             nqp::stmts(
-                                 ($target.push(nqp::atpos($!list,$!elems.rand.floor))),
-                                 ($!todo = $!todo - 1)
+                         nqp::stmts(
+                             (my int $todo  = $!todo),
+                             (my int $elems = $!elems),
+                             nqp::while(
+                                 $todo,
+                                 nqp::stmts(
+                                     ($target.push(nqp::atpos($!list,$elems.rand.floor))),
+                                     ($todo = $todo - 1)
+                                 )
                              )
                          )
                      }