Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure.DESTROY warning sometimes warns when Failure was technically handled #1502

Open
zoffixznet opened this issue Feb 8, 2018 · 0 comments

Comments

@zoffixznet
Copy link
Contributor

zoffixznet commented Feb 8, 2018

Originally started in #1298 This problem was spotted in one of our tests.

Usually Failure.DESTROY warning about unhandled Failures is good, but there is this edge case where more than one Failure is involved:

22:04 |   | e: use Test; for ^1000 { my $ = Failure.new < Failure.new; CATCH { default {} } }
-- | -- | --
22:04 | evalable6 | Zoffix, rakudo-moar 8ba3c86e7: OUTPUT: «WARNING: unhandled Failure detected in DESTROY. If you meant to ignore it, you can mark it…»
22:04 |   | Zoffix, Full output: https://gist.github.com/06e558ac81c8f261ad2d9c5236b06cfa

The exlosion happens when .Real is called inside < op, but the explosion of the first Failure prevents the second Failure from ever exploding, resulting in warnings for failures that weren't technically left unhandled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant