Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SET_VARIABLE is almost just DEFINE_VARIABLE #237

Open
Jeremi360 opened this issue May 17, 2023 · 2 comments
Open

SET_VARIABLE is almost just DEFINE_VARIABLE #237

Jeremi360 opened this issue May 17, 2023 · 2 comments
Labels
bug Something isn't working enhancement New feature or request majorChange Add this pr to changelog and should describe it RakuScript Rakugo Scripting Dialogue Langue
Milestone
2.3

Comments

@Jeremi360
Copy link
Contributor

Jeremi360 commented May 17, 2023 •
edited
Loading

I also just realize that our SET_VARIABLE is almost just DEFINE_VARIABLE,
in script is only possible to do x = 2 and x = 3, but can't do x = 2 + 1 or x += 1 or logic in it x = a or b - this is bad!
It means that now for base math and logic user need to add custom regex and it shouldn't be this way.
@Jeremi360 Jeremi360 added bug Something isn't working enhancement New feature or request RakuScript Rakugo Scripting Dialogue Langue majorChange Add this pr to changelog and should describe it labels May 17, 2023
@Jeremi360 Jeremi360 mentioned this issue May 17, 2023
Open
@Jeremi360
Copy link
Contributor Author

Jeremi360 commented May 26, 2023 •
edited
Loading

I made some code for this #240
I make new tests soon :D

@Jeremi360 Jeremi360 mentioned this issue May 26, 2023
Closed
@theludovyc theludovyc mentioned this issue Oct 27, 2023
Closed
@Jeremi360
Copy link
Contributor Author

patrially fixed by #262

@theludovyc theludovyc added this to the 2.1.3 milestone Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request majorChange Add this pr to changelog and should describe it RakuScript Rakugo Scripting Dialogue Langue
Projects
None yet
Milestone
2.3
Development

Successfully merging a pull request may close this issue.

Real set variable Jeremi360/Rakugo
2 participants
@Jeremi360 @theludovyc