Fix #88 : Save load thread #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add possibility to save last script have run.
theludovyc
force-pushed
the
fix#88_save_load_thread
branch
from
68e10d1
to
991e37b
Compare
|
Ready for review 🥳 |
Jeremi360
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #88
Major change
Rakugo.save_game(), now save name of current executed script, plus last line read. So with
Rakugo.load_game(), now parse last executed script.
Rakugo.resume_loaded_script(), run last executed script.
We split load in 2 funcs. So you can call Rakugo.load_game(), to loads variables as usual and load your scenes with them. And after everything is ready, call Rakugo.execute_last_script().
Bug
Fix wait_character_variable_changed, now it call assert_variable correctly : char_tag+"."+var_name