Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add singletons through add_autoload_singleton() #100

Closed
Tracked by #98
Jeremi360 opened this issue Oct 17, 2021 · 5 comments · Fixed by #102
Closed
Tracked by #98

add singletons through add_autoload_singleton() #100

Jeremi360 opened this issue Oct 17, 2021 · 5 comments · Fixed by #102
Assignees
@Jeremi360
Labels
code Changes in how Rakugo core works enhancement New feature or request high high priority
Projects
3.3

Comments

@Jeremi360
Copy link
Contributor

Jeremi360 commented Oct 17, 2021 •
edited
Loading

singletons are not added through add_autoload_singleton()
@Jeremi360 Jeremi360 mentioned this issue Oct 17, 2021
Closed
2 tasks
@Jeremi360 Jeremi360 self-assigned this Oct 17, 2021
@Jeremi360 Jeremi360 added code Changes in how Rakugo core works enhancement New feature or request high high priority labels Oct 17, 2021
@Jeremi360 Jeremi360 added this to To do in 3.3 Oct 17, 2021
@Jeremi360 Jeremi360 added this to the 3.3 milestone Oct 17, 2021
@theludovyc
Copy link
Contributor

theludovyc commented Oct 23, 2021 •
edited
Loading

I take it o/

@theludovyc
Copy link
Contributor

image
Do you want to make add_autoload_singleton() on Window ? If yes, how ? :)

@theludovyc theludovyc mentioned this issue Oct 23, 2021
Merged
@Jeremi360
Copy link
Contributor Author

image Do you want to make add_autoload_singleton() on Window ? If yes, how ? :)

@theludovyc Yes and No, I want this to be added as singleton, but only for gui.
But we call add_autoload_singleton() only from EditorPlugin.
So I think now Window singleton should be a part of project.godot included in BoundleVN.

@theludovyc
Copy link
Contributor

Ok 😊 ! So ready for review !

@Jeremi360 Jeremi360 linked a pull request Oct 23, 2021 that will close this issue
Fixing Issue#100 #102
Merged
@Jeremi360
Copy link
Contributor Author

Ok 😊 ! So ready for review !

@theludovyc reviewed and merged 😄

3.3 automation moved this from To do to Done Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeremi360 Jeremi360

Labels
code Changes in how Rakugo core works enhancement New feature or request high high priority
Projects
No open projects
3.3
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing Issue#100
2 participants
@Jeremi360 @theludovyc