Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added boolean and file attribute type support #65

Merged
merged 1 commit into from Apr 11, 2022

Conversation

rcerljenko
Copy link

Added support for boolean and file|image attribute types

@kevincobain2000
Copy link
Member

Noted, and thanks for the contribution. Will check it over the weekend.

@kevincobain2000 kevincobain2000 changed the base branch from master to develop April 11, 2022 13:35
@kevincobain2000 kevincobain2000 merged commit b12a31f into rakutentech:develop Apr 11, 2022
@kevincobain2000
Copy link
Member

Looked cool! Thanks merged and published

@rcerljenko
Copy link
Author

Thanks!

@rcerljenko
Copy link
Author

@kevincobain2000 just a thought...
my company uses this library for exporting backend API routes... eg. our frontend developers can easily inspect what to pass in api requests and view responses also

would you accept a PR where we give that index page some UI overhaul? since we use Vue.js in our frontend stack, our frontend developers would be willing to give that page a little UI boost to look modern

what do you say?

@kevincobain2000
Copy link
Member

kevincobain2000 commented Apr 12, 2022

Hi @rcerljenko
Thanks for the support. I am glad that the library is helpful to you.
Mostly all the open issues right now are related to UI lift in one way or the other.
Yea, I'd be up for it and merge it.
The one important item about the current design is the use of HTML table, which enables us to copy it to the clipboard & paste it, as it is, since table inside Confluence/MS Teams chat etc. Apart from that, feel free to even bring major changes such use xxx instead of prism or get rid of tailwind all together.

#6
#16
#51
#52
#53

@rcerljenko
Copy link
Author

Thanks for the green light! I'll talk with my frontend team tomorrow and see if we could manage that. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants