Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is a great library, when will it support MacOS #4

Closed
chengpan168 opened this issue Feb 24, 2022 · 4 comments
Closed

This is a great library, when will it support MacOS #4

chengpan168 opened this issue Feb 24, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@chengpan168
Copy link

This is a great library, when will it support MacOS

@rakuyoMo
Copy link
Member

rakuyoMo commented Feb 24, 2022

This is a great library, when will it support MacOS

This is a great idea, let's discuss it further:

JSONPreview can now be used with programs running as Mac Catalyst.

do you mean introducing AppKit under macOS? Something like the following

#if os(macOS)
import AppKit
#else
import UIKit
#endif

@rakuyoMo rakuyoMo added the enhancement New feature or request label Feb 24, 2022
@chengpan168
Copy link
Author

Ok, one of my open source software written with Swiftui uses SwiftyJSON to format JSON, but there is no highlighting. I am a beginner Apple developer, so I don't know whether such integration is possible in Swiftui, thank you very much

@rakuyoMo
Copy link
Member

rakuyoMo commented Feb 28, 2022

Ok, one of my open source software written with Swiftui uses SwiftyJSON to format JSON, but there is no highlighting. I am a beginner Apple developer, so I don't know whether such integration is possible in Swiftui, thank you very much

Then what you need should be support for both SwiftUI and macOS.

But unfortunately I know very little about both, especially SwiftUI...

I noticed that redis-pro's to-do list has plans for iPad support, so I have a suggestion: try using Mac Catalyst technology.

It allows applications built on iOS to run on macOS. Only a few code changes are required, such as support for keyboard shortcuts. Since you're using SwiftUI, it shouldn't be difficult to switch your existing code to the iOS platform either.

The future JSONPreview may support SwiftUI in a better way, but I don't think it will come soon, possibly later this year.

As for support for macOS, that's not in my plans for now. Thanks to wrapping, there isn't a lot of logic scattered throughout the JSONPreview view code, which should be good news for getting it to support macOS, but the problem is that I don't have time to get into AppKit at the moment...

Or maybe someone who sees this issue can provide a PR to help make it better. I'd appreciate it.

@chengpan168
Copy link
Author

Okay, thank you very much, I will try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants