Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open must Close if magic_setflags or magic_load fails #19

Closed
rakyll opened this issue Dec 9, 2015 · 0 comments
Closed

Open must Close if magic_setflags or magic_load fails #19

rakyll opened this issue Dec 9, 2015 · 0 comments

Comments

@rakyll
Copy link
Owner

rakyll commented Dec 9, 2015

Currently, Open sequence doesn't handle the case where magic_setflags and magic_load fails. We need to close magic and free the underlying resources.

Also, we must document that Close must be called once user is done with magic.

@rakyll rakyll closed this as completed in 110abe2 Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant