DLS data publications views #1532 #1533 #1538

louise-davies · 2023-06-14T08:46:11Z

Description

Adding the DOI landing pages, which have a details tab & a content tab which shows the investigations, datasets and datafiles contained in the data publication. Also adds the My DOI view, which has a table of the DOIs the logged in user has minted.

See screenshots:

It's still a WIP - I haven't written any tests and I still have some strings hard coded instead of put in the default.json - but I figured these are a lesser priority than just getting a working feature out. There's also a few TODOs still - I need to sort out the breadcrumbs on the DLS DOI landing pages, and there's a visual bug with the content table if you switch from Datasets to one of the other tabs when that tab is empty and then switch back to datasets.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

Review code
Check Actions build
Review changes to test coverage
Deploy with other PR & Alex's minting backend to test the DOI minting workflow

Agile board tracking

Closes #1532, Closes #1533

codecov · 2023-07-19T12:53:46Z

Codecov Report

Attention: Patch coverage is 94.85981% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 96.24%. Comparing base (03624bf) to head (d715a0d).

❗ Current head d715a0d differs from pull request most recent head 5cbd215. Consider uploading reports for the commit 5cbd215 to get more accurate results

Files	Patch %	Lines
...g/dls/dlsDataPublicationContentTable.component.tsx	92.30%	5 Missing ⚠️
...es/datagateway-common/src/api/dataPublications.tsx	88.88%	4 Missing ⚠️
...w/src/views/table/dls/dlsMyDOIsTable.component.tsx	92.30%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1538      +/-   ##
===========================================
- Coverage    96.25%   96.24%   -0.02%     
===========================================
  Files          170      165       -5     
  Lines         7326     7076     -250     
  Branches      2330     2181     -149     
===========================================
- Hits          7052     6810     -242     
+ Misses         254      246       -8     
  Partials        20       20

Flag	Coverage Δ
common	`95.44% <90.00%> (+0.12%)`	⬆️
dataview	`96.79% <95.97%> (-0.58%)`	⬇️
download	`96.84% <ø> (+0.85%)`	⬆️
search	`96.50% <ø> (-0.05%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

louise-davies · 2023-11-20T10:32:05Z

TODO: add versioning panel to both concept & version landing pages

Also might need to filter out version DOIs somehow from the table view

Also need to add an edit button to landing pages to create new versions (need to think which DOI pages provide this button e.g. only latest version allows editing? does the concept get to be edited?)

Check SEO stuff?

Might need to check versioning redirect stuff

Still need to get the API to work re: only concepts can be edited, but concepts have no content

Need to get content from version DOI API is currently broken so need to wait for a fix for further testing

Probably broke in merge conflict resolution with sizes & counts refactor

- Add dates to versioning panel & ensure we order by createTime - Show latest version DOI more prominently - Remove concept panel in favour of concept short info item

codecov-commenter · 2024-03-21T09:42:35Z

Codecov Report

Attention: Patch coverage is 93.25843% with 42 lines in your changes missing coverage. Please review.

Project coverage is 96.11%. Comparing base (03624bf) to head (7a65d00).
Report is 14 commits behind head on develop.

Files	Patch %	Lines
packages/datagateway-common/src/api/dois.tsx	82.82%	16 Missing and 1 partial ⚠️
...es/datagateway-common/src/api/dataPublications.tsx	83.33%	8 Missing ⚠️
...nding/dls/dlsDataPublicationEditForm.component.tsx	93.40%	6 Missing ⚠️
...g/dls/dlsDataPublicationContentTable.component.tsx	92.30%	5 Missing ⚠️
...mon/src/dois/creatorsAndContributors.component.tsx	80.00%	3 Missing ⚠️
...ateway-dataview/src/page/pageRouting.component.tsx	80.00%	1 Missing ⚠️
...w/src/views/table/dls/dlsMyDOIsTable.component.tsx	95.83%	1 Missing ⚠️
packages/datagateway-download/src/App.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1538      +/-   ##
===========================================
- Coverage    96.25%   96.11%   -0.15%     
===========================================
  Files          170      179       +9     
  Lines         7326     7806     +480     
  Branches      2330     2485     +155     
===========================================
+ Hits          7052     7503     +451     
- Misses         254      281      +27     
- Partials        20       22       +2

Flag	Coverage Δ
common	`94.91% <84.78%> (-0.42%)`	⬇️
dataview	`97.28% <96.89%> (-0.08%)`	⬇️
download	`96.06% <95.00%> (+0.07%)`	⬆️
search	`96.55% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

louise-davies · 2024-06-12T12:46:29Z

We need to allow for the API urls to be configured by env variables in a Docker container

louise-davies · 2024-06-14T15:30:17Z

Also, need to add something like this to the default settings:

{
      "section": "Browse",
      "link": "/browse/dataPublication",
      "displayName": "DLS DataPublications",
      "order": 8,
      "hideFromMenu": true
},

louise-davies added 3 commits June 12, 2023 09:41

#1532 - add basic DLS landing page

ea73f10

#1532 - add content table to DLS DOI landing page

bfc5578

#1533 - Add My DOIs view

69d603a

louise-davies requested a review from moonraker595 June 14, 2023 08:46

louise-davies added 4 commits June 20, 2023 13:23

#1532 - fix issues with content table and fix routing issues

cf95162

#1532 - improve DLS landing page UI

1c1a757

#1532 - add tests for data publication api endpoints

bedce9a

#1532 - Fix circular dependency

f89729c

louise-davies added 5 commits July 20, 2023 11:28

#1532 - add translations + unit tests for DLS DOI landing page

a8cddae

#1533 - add unit tests for my DOIs view

629f81c

#1532 #1533 add e2e tests

5d24236

#1532 #1533 - fix e2e tests broken by different timezones

4a5c021

#1533 - fix e2e date

d715a0d

louise-davies marked this pull request as ready for review July 28, 2023 13:04

louise-davies requested review from patrick-austin and removed request for moonraker595 August 4, 2023 09:53

louise-davies added the WIP This PR is still being worked on and should not merged label Dec 12, 2023

louise-davies added 7 commits January 18, 2024 09:52

Merge branch 'develop' into feature/dls-data-publications-#1532-#1533

334a4af

#1532 - add basic version table & have WIP edit form

bc8f4fc

Still need to get the API to work re: only concepts can be edited, but concepts have no content

#1532 #1533 - only show concept dois and fix editing form

84c9498

Need to get content from version DOI API is currently broken so need to wait for a fix for further testing

Merge branch 'develop' into feature/dls-data-publications-#1532-#1533

d7bc602

#1532 - improve version panel & landing page

2a3d453

#1532 - fix unit tests & tidy up some code

ae3349d

Fix wrong import & refactor e2e test for my dois table #1533

729e0e3

louise-davies force-pushed the feature/dls-data-publications-#1532-#1533 branch from d4fccfe to 729e0e3 Compare March 15, 2024 15:52

louise-davies added 3 commits March 18, 2024 11:57

Fix missing import

5cbd215

Probably broke in merge conflict resolution with sizes & counts refactor

#1532 - fix unit tests & refactor DOI api error handling

1f0a8ed

Refactor translation key to match what's in the JSON file

de0b29f

#1532 - adjust concept/version DOI stuff

490d6aa

- Add dates to versioning panel & ensure we order by createTime - Show latest version DOI more prominently - Remove concept panel in favour of concept short info item

louise-davies added 10 commits March 22, 2024 11:41

#1533 - update unit tests with landing page changes

98eaeb6

#1532 - add unit tests for doi version editing

45ed831

#1532 - allow users to edit data when generating a new version

92ebbd1

#1532 - add unit tests for data publication content editing

d729975

#1532 - fix tests broken by useIsCartMintable moving to dg-common

f956415

#1532 - Fix broken ids in citation formatter

f29bbfd

#1532 - fix more tests broken by useIsCartMintable moving to dg-common

67a04c3

#1532 - add e2e tests for DOI versioning

f2cbfb3

#1532 - fix test broken by edit button label key change

7e361ce

#1532 #1533 - invalidate queries after updating data pubs

7a65d00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DLS data publications views #1532 #1533 #1538

DLS data publications views #1532 #1533 #1538

louise-davies commented Jun 14, 2023

codecov bot commented Jul 19, 2023 •

edited

louise-davies commented Nov 20, 2023

codecov-commenter commented Mar 21, 2024 •

edited by codecov bot

louise-davies commented Jun 12, 2024

louise-davies commented Jun 14, 2024

DLS data publications views #1532 #1533 #1538

Are you sure you want to change the base?

DLS data publications views #1532 #1533 #1538

Conversation

louise-davies commented Jun 14, 2023

Description

Testing instructions

Agile board tracking

codecov bot commented Jul 19, 2023 • edited

Codecov Report

louise-davies commented Nov 20, 2023

codecov-commenter commented Mar 21, 2024 • edited by codecov bot

Codecov Report

louise-davies commented Jun 12, 2024

louise-davies commented Jun 14, 2024

codecov bot commented Jul 19, 2023 •

edited

codecov-commenter commented Mar 21, 2024 •

edited by codecov bot