-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omp_get_nested routine deprecated #124
Comments
@mjacobse any thoughts on how best to fix these warnings? The issue with using Ideally I would want to get rid of the need to set the three OMP variables:
before running the code as this is tedious and not user-friendly. I fail to understand why the OpenMP standard does not have a programmatic way of setting these in the code. |
I am not really too familar with these advanced OpenMP features. As far as I can tell from the documentation, using For the nested setting, this already seems to be done programmatically anyways: Lines 1459 to 1461 in 4ec8797
Lines 1467 to 1469 in 4ec8797
I even think the second of these sections does nothing at all right now, since !$ user_settings%max_active_levels = omp_get_max_active_levels()
!$ if (user_settings%max_active_levels .lt. 2) call omp_set_max_active_levels(omp_get_supported_active_levels()) would be the non-deprecated, equivalent version. But just deleting the first section and keeping the second section should also work and not be deprecated. |
Thanks @mjacobse, that's great news! I will create a PR to delete the first section as this seems cleanest. I still find it deeply annoying that cancellation can only be enabled via the setting of an environment variable, who on the OpenMP standards committee actually thought that was a good idea? |
In GALAHAD, we have the following warning if we compile with Intel compilers:
https://www.openmp.org/spec-html/5.0/openmpsu120.html
https://www.openmp.org/spec-html/5.0/openmpsu126.html
The text was updated successfully, but these errors were encountered: