Wi-Fi credentials with spaces fail

[phoddie]

When using a Wi-Fi SSID or password that contains spaces, the MCU plug-in generates an invalid command line. For example, if the SSID is "Moddable WiFi" this is the command line:

mcconfig -d -x localhost:5004 -m -p esp/nodemcu ssid=Moddable WiFi password=xyzzy

The correct command line is:

mcconfig -d -x localhost:5004 -m -p esp/nodemcu ssid="Moddable WiFi" password=xyzzy

A password with spaces fails in the same way.

I tried putting entering quotes in the "WiFi | SSID" field, but they are removed.

[ralphwetzel]

Thank you for reporting this!
Should be fixed now by a commit a few minutes ago.
Would be great if you find time to give it a try...

[phoddie]

Thanks. That works much better.

FWIW – It fails for values that contain " or '' but that's probably enough of an edge case that it isn't worth addressing now.

[ralphwetzel]

It fails for values that contain " or ''...

Thank you for this heads-up. You're fully right.
I've refactored it once again - to omit dancing with the oddities of the various command lines. Handover of this data is now performed via the config arguments in the manifest.json.

[phoddie]

Thanks for taking care of that. It is enough of an edge case that I didn't expect it!