Feature/verifying target object has all needed dependencies #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Verifying that target object has all needed dependencies | ||
| for (NSString *propertyName in dependencies) { | ||
| XCTAssertTrue([propertyNames containsObject:propertyName], @"У объекта %@ не было найдено свойство %@", targetObject, propertyName); |
There was a problem hiding this comment.
We use English language in this project
There was a problem hiding this comment.
@igrekde Do you mean this comment?
У объекта %@ не было найдено свойство %@
There was a problem hiding this comment.
Hmm...however, project has some Russian comments, like this:
XCTAssertNotNil(dependencyObject, @"Свойство %@ объекта %@ не должно быть nil", propertyName, targetObject);
|
@spbvasilenko thanks for your contribution! One small fix and we are done! |
|
@igrekde In the last commit this is comment has been fixed |
|
Great, today I'll release a new version! |
etolstoy
added a commit
that referenced
this pull request
Jan 11, 2016
…ct-has-all-needed-dependencies Feature/verifying target object has all needed dependencies
|
@igrekde Thank you! |
vasilenkoigor
deleted the
feature/verifying-target-object-has-all-needed-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm added case for verifying that target object has all needed dependencies.
This is pull request for 4 issue