Leaderboard: final touches #3
Conversation
There was a problem hiding this comment.
STATUS: APPROVED ♻️♻️
Hi @raminka13 👋🏿👋🏿👋🏿,
Your project is complete! There is nothing else to say other than... it's time to merge it 🚀
Congratulations! 🎉
TO HIGHLIGHT:
- Your project is professional ✔️
- Correct Github Flow ✔️
- Your PR has a proper title and description ✔️
- Well structured files ✔️
Required Changes ♻️
Please check the comments under the review as well.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
- [OPTIONAL] Even though your readme looks great I think it is better to use Microverse's readme template. At least the order of sections should be similar to Microverse's template. I think the first section after the title of the project should be the project description not the snapshot of the project.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| min-height: 40px; | ||
| max-height: 450px; | ||
| overflow-y: auto; | ||
| background-color: #fff; |
There was a problem hiding this comment.
- [OPTIONAL] I think there should be a gap between the scores list and scores header containers. You can give top margins for the scores list container or you could use flex for the parent container and give gap value to it.
Styles and notifications improvements ⚔️