Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing To Do list: part 2 #6

Merged
merged 2 commits into from Jul 14, 2022
Merged

Testing To Do list: part 2 #6

merged 2 commits into from Jul 14, 2022

Conversation

raminka13
Copy link
Owner

Test Edit and Delete All Functions

  • We install JSDOM as a global npm module to mock DOM and localStorage.
  • We created a test to edit text in task input and should be saved to localStorage.
  • We created a test to edit checkbox state and new checkbox state should be saveb to localStorage.
  • We created a test to delete all the completed task and the resulting array should be saved to localStorage.
  • We created a test to reset all tasks and the resulting empty array should be saved to localStorage.

Copy link

@ahmetbozaci ahmetbozaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 🎉🥇 💯 💥 🎆 🎈 STATUS: APPROVED 🥳 🎉 🥇 💯 💥 🎆 🎈 🎉

@raminka13 ✋🏼

Your project is great. 🎉 I approve of it. There is nothing else to say other than... it's time to merge it. You can submit this project on your dashboard.


💯 Nice to have 💯

  • Your git-flow is correct. ✔️
  • You set up linter files and no errors. ✔️
  • Your pull request is very professional. It has a meaningful title and summary. Keep it up.✔️
  • You added tests according to requirements and all tests are passed.✔️
    image

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.


Cheers and Happy coding! 💻 👏

aproved


Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

GitHub | LinkedIn | Twitter

Reviewed by Ahmet Bozacı

@raminka13 raminka13 merged commit 36cb196 into main Jul 14, 2022
@raminka13 raminka13 deleted the jest2 branch July 14, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants