Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make functions that search by either efo_trait or reported_trait case sensitive again #17

Closed
ramiromagno opened this issue Dec 29, 2020 · 0 comments
Closed

Make functions that search by either efo_trait or reported_trait case sensitive again #17

ramiromagno opened this issue Dec 29, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@ramiromagno
Copy link
Owner

Remove the wrap in tolower() in these cases:

get_studies_by_efo_trait

gwasrapidd/R/get_studies.R

Line 441 in 700c86f

urltools::url_encode(tolower(efo_trait)))

get_studies_by_reported_trait

gwasrapidd/R/get_studies.R

Line 491 in 700c86f

urltools::url_encode(tolower(reported_trait)))

get_variants_by_efo_trait

gwasrapidd/R/get_variants.R

Line 459 in 700c86f

urltools::url_encode(tolower(efo_trait)))

get_variants_by_reported_trait

gwasrapidd/R/get_variants.R

Line 513 in 700c86f

urltools::url_encode(tolower(reported_trait)))

get_associations_by_efo_trait

gwasrapidd/R/get_associations.R

Line 295 in 700c86f

urltools::url_encode(tolower(efo_trait)))

get_traits_by_efo_trait

gwasrapidd/R/get_traits.R

Line 278 in 700c86f

urltools::url_encode(tolower(efo_trait)))

@ramiromagno ramiromagno added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ramiromagno